fix: add missing include to fix vaex-core build with gcc-13#2450
Merged
maartenbreddels merged 1 commit intovaexio:masterfrom Feb 4, 2026
Merged
fix: add missing include to fix vaex-core build with gcc-13#2450maartenbreddels merged 1 commit intovaexio:masterfrom
maartenbreddels merged 1 commit intovaexio:masterfrom
Conversation
ddelange
approved these changes
Jan 17, 2025
Contributor
|
@mgorny master now contains the latest fixes for CI and numpy v2 support |
maartenbreddels
force-pushed
the
master
branch
from
c8549a7 to
f304f80
Compare
Member
|
Is this still needed? |
Contributor
|
i think yes, we're currently on gcc-12 in CI #2382 (comment) |
maartenbreddels
force-pushed
the
gcc-build
branch
from
8db06ba to
2b4358b
Compare
Contributor
Author
|
Yes, that was still necessary indeed, and with the patch applied, I can build |
Contributor
|
fyi manylinux_2_28 (cibuildwheel docker image in which we build vaex-core) now has GCC 14 as toolchain: https://github.com/pypa/manylinux#manylinux_2_28-almalinux-8-based |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2382